[
https://issues.apache.org/jira/browse/OAK-4770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15483575#comment-15483575
]
Marcel Reutegger commented on OAK-4770:
---------------------------------------
Discussed with Stefan offline and the intention of the AssertionError was to
break through try/catches and terminate the current thread. But the lease
update thread currently also catches errors and will not terminate. I will
therefore try to replace usage of AssertionError with DocumentStoreException
and update the contract of renewLease() accordingly.
> Missing exception handling in ClusterNodeInfo.renewLease()
> ----------------------------------------------------------
>
> Key: OAK-4770
> URL: https://issues.apache.org/jira/browse/OAK-4770
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: core, documentmk
> Reporter: Marcel Reutegger
> Assignee: Marcel Reutegger
> Labels: resilience
> Fix For: 1.6
>
>
> ClusterNodeInfo.renewLease() does not handle a potential
> DocumentStoreException on {{findAndModify()}}. This may leave
> {{previousLeaseEndTime}} in an inconsistent state and a subsequent
> {{renewLease()}} call then considers the lease timed out.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
