[ https://issues.apache.org/jira/browse/OAK-2498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15542217#comment-15542217 ]
Francesco Mari commented on OAK-2498: ------------------------------------- The refinements looks incorrect to me. Let's say that {{ids}} contains records {{S:1}} and {{S:2}} and segment {{S}} is not referenced by the current segment. In this case, the current implementation would increment {{referencedIdCount}} by 2, while it should have been incremented by 1 instead. On the other hand, if segment {{S}} is already referenced by the current segment, the current implementation would increment {{referencedIdCount}} by 1, while it shouldn't have been incremented at all. > Root record references provide too little context for parsing a segment > ----------------------------------------------------------------------- > > Key: OAK-2498 > URL: https://issues.apache.org/jira/browse/OAK-2498 > Project: Jackrabbit Oak > Issue Type: Bug > Components: segment-tar > Reporter: Michael Dürig > Assignee: Francesco Mari > Labels: tools > Fix For: Segment Tar 0.0.14 > > > According to the [documentation | > http://jackrabbit.apache.org/oak/docs/nodestore/segmentmk.html] the root > record references in a segment header provide enough context for parsing all > records within this segment without any external information. > Turns out this is not true: if a root record reference turns e.g. to a list > record. The items in that list are record ids of unknown type. So even though > those records might live in the same segment, we can't parse them as we don't > know their type. -- This message was sent by Atlassian JIRA (v6.3.4#6332)