[
https://issues.apache.org/jira/browse/OAK-4883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15548300#comment-15548300
]
Timothee Maret commented on OAK-4883:
-------------------------------------
Thanks [~alexparvulescu] for clarifying.
With the current code (segment-tar) a standby instance will not instantiate a
{{SegmentNodeStore}} due to the check at [0]. AFAIU, this was introduced in
OAK-4089 (before the code that issue, the code was registering a
{{SegmentNodeStore}}).
A {{SegmentNodeStore}} seems to be required in order to register a
{{BlobGCMBean}}.
Indeed the {{BlobGCMBean}} needs a {{MarkSweepGarbageCollector}} which needs a
{{repoId}} which is obtained via a {{SegmentNodeStore}}.
AFAIU, we'd need to register a {{SegmentNodeStore}} while keeping the fix for
OAK-4089.
[~frm] in OAK-4089 you wrote:
bq. It would be more appropriate not to instantiate the observation subsystem
at all in the context of the standby store, thus preventing spurious references
to SegmentId instances to float in memory.
With "observation subsystem", were you referring to the {{observerTracker}} in
[1] ?
If so, how about building a {{SegmentNodeStore}} in any case, but only avoid
registering {{observerTracker}} for standby instances ?
[0]
https://github.com/apache/jackrabbit-oak/blob/2b6c2f5340f3b6485dda5c493f6343d232c883e9/oak-segment/src/main/java/org/apache/jackrabbit/oak/plugins/segment/SegmentNodeStoreService.java#L374
[1]
https://github.com/apache/jackrabbit-oak/blob/2b6c2f5340f3b6485dda5c493f6343d232c883e9/oak-segment/src/main/java/org/apache/jackrabbit/oak/plugins/segment/SegmentNodeStoreService.java#L595
> Missing BlobGarbageCollection MBean on standby instance
> -------------------------------------------------------
>
> Key: OAK-4883
> URL: https://issues.apache.org/jira/browse/OAK-4883
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: segment-tar, segmentmk
> Reporter: Alex Parvulescu
> Assignee: Timothee Maret
> Labels: gc
>
> The {{BlobGarbageCollection}} MBean is no longer available on a standby
> instance, this affects non-shared datastore setups (on a shared datastore
> you'd only need to run blob gc on the primary).
> This change was introduced by OAK-4089 (and backported to 1.4 branch with
> OAK-4093).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
