[ 
https://issues.apache.org/jira/browse/OAK-4926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15568025#comment-15568025
 ] 

Francesco Mari commented on OAK-4926:
-------------------------------------

I think the patch can be further simplified by using 
{{FileStore.containsSegment()}} instead. [~marett], can you give a try at this 
solution?

> o.a.j.o.s.s.c.StandbyClientSyncExecution#isLocal should expect missing segment
> ------------------------------------------------------------------------------
>
>                 Key: OAK-4926
>                 URL: https://issues.apache.org/jira/browse/OAK-4926
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: segment-tar
>    Affects Versions: Segment Tar 0.0.14
>            Reporter: Timothee Maret
>            Assignee: Timothee Maret
>             Fix For: Segment Tar 0.0.16
>
>         Attachments: OAK-4926.patch
>
>
> Currently the method 
> {{org.apache.jackrabbit.oak.segment.standby.client.StandbyClientSyncExecution#isLocal}}
>  does invoke
> {code}
> referencedId.getSegment();
> {code}
> in order to read the referenced segment. In case of missing segment, the 
> {{ReferenceId.getSegment}} does throw a SNFE *and* logs an ERROR level 
> statement. The SNFE is needed but not the log statement in this case.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to