[ https://issues.apache.org/jira/browse/OAK-4450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15565351#comment-15565351 ]
Alex Parvulescu edited comment on OAK-4450 at 10/12/16 12:47 PM: ----------------------------------------------------------------- WIP at [0] and [1] [~mduerig], [~frm] feedback appreciated! [0] https://github.com/stillalex/jackrabbit-oak/commit/148296b1ac6f4a96ae24cff60c3116d774052664 [1] https://github.com/stillalex/jackrabbit-oak/commit/01fbc8311e467996be5c5116dd445d356af6db9b was (Author: alex.parvulescu): WIP at https://github.com/stillalex/jackrabbit-oak/commit/148296b1ac6f4a96ae24cff60c3116d774052664 [~mduerig], [~frm] feedback appreciated! > Properly split the FileStore into read-only and r/w variants > ------------------------------------------------------------- > > Key: OAK-4450 > URL: https://issues.apache.org/jira/browse/OAK-4450 > Project: Jackrabbit Oak > Issue Type: Technical task > Components: segment-tar > Reporter: Michael Dürig > Assignee: Michael Dürig > Labels: technical_debt > Fix For: Segment Tar 0.0.18 > > > The {{ReadOnlyFileStore}} class currently simply overrides the {{FileStore}} > class replacing all mutator methods with a trivial implementation. This > approach however leaks into its ancestor as the read only store needs to pass > a flag to the constructor of its super class so some fields can be > instantiated properly for the read only case. > We should clean this up to properly separate the read only and the r/w store. > Most likely we should factor the commonalities into a common, abstract base > class. -- This message was sent by Atlassian JIRA (v6.3.4#6332)