[ https://issues.apache.org/jira/browse/OAK-5002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15605516#comment-15605516 ]
Alex Parvulescu edited comment on OAK-5002 at 10/25/16 2:54 PM: ---------------------------------------------------------------- hmm, I added this method to not have to change the {{ConsistencyChecker}}, maybe it was not such a great thing. see [0] for my original change, if this looks ok we could drop {{SegmentNodeStoreBuilders#builder}} completely. [edit] now I see the console thing, ok, dropping is not an option. [0] https://github.com/stillalex/jackrabbit-oak/commit/148296b1ac6f4a96ae24cff60c3116d774052664#diff-0c673f42a163ddb32ae5a75a2f06595dR149 was (Author: alex.parvulescu): hmm, I added this method to not have to change the {{ConsistencyChecker}}, maybe it was not such a great thing. see [0] for my original change, if this looks ok we could drop {{SegmentNodeStoreBuilders#builder}} completely. [0] https://github.com/stillalex/jackrabbit-oak/commit/148296b1ac6f4a96ae24cff60c3116d774052664#diff-0c673f42a163ddb32ae5a75a2f06595dR149 > NPE when creating read only store > --------------------------------- > > Key: OAK-5002 > URL: https://issues.apache.org/jira/browse/OAK-5002 > Project: Jackrabbit Oak > Issue Type: Bug > Components: segment-tar > Reporter: Michael Dürig > Assignee: Michael Dürig > Fix For: Segment Tar 0.0.18 > > > Using > {{org.apache.jackrabbit.oak.segment.SegmentNodeStoreBuilders#builder(org.apache.jackrabbit.oak.segment.file.ReadOnlyFileStore)}} > to create a read only store results in a NPE: > {noformat} > Exception in thread "main" java.lang.NullPointerException > at > com.google.common.base.Preconditions.checkNotNull(Preconditions.java:192) > at > org.apache.jackrabbit.oak.segment.SegmentNodeStore.builder(SegmentNodeStore.java:148) > at > org.apache.jackrabbit.oak.segment.SegmentNodeStoreBuilders.builder(SegmentNodeStoreBuilders.java:69) > {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332)