[
https://issues.apache.org/jira/browse/OAK-5046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15632404#comment-15632404
]
Alex Parvulescu commented on OAK-5046:
--------------------------------------
bq. we want to get rid of everything involving the old compaction gain
threshold, but properties like GAIN_THRESHOLD_DEFAULT are still to be kept
I'm not sure who 'we' is, but I'm in favor of keeping the old estimation bits
around (not enabled by default), with the option of enabling it via a system
property.
bq. although we want to switch to the new implementation, a property from the
old one is used to make the decision of running the estimation, or not
(gainThreshold).
whatever you think is best here. I'm not sure what the plan would be, I would
not add a new property, just hide the decision mechanics behind a dedicated
method, {{disableEstimation}} as you called it.
bq. I don't know all the details behind, but having a threshold expressed as a
percentage (the old compaction gain), seems more natural than having one based
on a value in gigabytes.
no preference, but this does seem outside of this issue's scope. you could
provide this as a patch on a dedicated issue.
bq. To sum up my proposal is to go all the way and remove everything related to
the old compaction gain, clarifying also the points above.
if there is no way of keeping both estimation options, and enable just one
based on config settings, then yeah, remove the old one completely.
> Remove the old estimation OSGi setting (compaction.gainThreshold)
> -----------------------------------------------------------------
>
> Key: OAK-5046
> URL: https://issues.apache.org/jira/browse/OAK-5046
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: segment-tar
> Affects Versions: 1.5.12
> Reporter: Andrei Dulceanu
> Assignee: Andrei Dulceanu
> Priority: Minor
> Labels: osgi-config
> Fix For: 1.5.13
>
> Attachments: OAK-5046-01.patch
>
>
> Currently, there are two implementations for finding out the gain in
> repository size after running compaction: the old one,
> {{CompactionGainEstimate}} and the new one, {{SizeDeltaGcEstimation}}.
> Similarly, there are also two configurations for customising them, in
> {{SegmentNodeStoreService}}, {{compaction.gainThreshold}} and
> {{compaction.sizeDeltaEstimation}}.
> At the moment both of them are exposed as OSGi configurations, but only the
> new one should be exposed (e.g. {{compaction.sizeDeltaEstimation}}).
> It must be evaluated whether it makes sense to keep the logic associated with
> the old implementation.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
