[ 
https://issues.apache.org/jira/browse/OAK-5082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15646954#comment-15646954
 ] 

Stefan Egli commented on OAK-5082:
----------------------------------

OAK-4908 is currently reverted, however a fix for OAK-5082 would have been (in 
ObservationManagerImpl.addEventListener):
{code}
        // OAK-5082 : node type filtering should not only be direct but include 
derived types
        // one easy way to solve this is to 'explode' the node types at start 
by including
        // all subtypes of every registered node type
        //TODO: what if there are multiple hierarchy levels, does subTypes 
return those too?
        HashSet<String> explodedNodeTypes = newHashSet();
        if (validatedNodeTypeNames != null) {
            for (String nt : validatedNodeTypeNames) {
                NodeTypeIterator it = ntMgr.getNodeType(nt).getSubtypes();
                while(it.hasNext()) {
                    String subnt = String.valueOf(it.next());
                    explodedNodeTypes.add(subnt);
                }
                explodedNodeTypes.add(nt);
            }
        }
{code}

> Test failure: 
> testDerivedMixin(org.apache.jackrabbit.core.observation.MixinTest)
> --------------------------------------------------------------------------------
>
>                 Key: OAK-5082
>                 URL: https://issues.apache.org/jira/browse/OAK-5082
>             Project: Jackrabbit Oak
>          Issue Type: Test
>          Components: jcr
>            Reporter: Amit Jain
>            Assignee: Marcel Reutegger
>
> Failed on travis - 
> https://travis-ci.org/apache/jackrabbit-oak/builds/173972640 as well as 
> locally.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to