[ 
https://issues.apache.org/jira/browse/OAK-5079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15647206#comment-15647206
 ] 

Chetan Mehrotra edited comment on OAK-5079 at 11/8/16 10:54 AM:
----------------------------------------------------------------

Changed done here 
https://github.com/chetanmeh/jackrabbit-oak/compare/trunk...chetanmeh:OAK-5079

And as [patch|^OAK-5079-v1.diff]. Actual fix is done in this 
[commit|https://github.com/chetanmeh/jackrabbit-oak/commit/8bbb56dfc98d347cf5c664c54b83c8284a6b538c]

[~mreutegg] Please review


was (Author: chetanm):
Changed done here 
https://github.com/chetanmeh/jackrabbit-oak/compare/trunk...chetanmeh:OAK-5079

> Diff would not work for bundled nodes when done without journal support
> -----------------------------------------------------------------------
>
>                 Key: OAK-5079
>                 URL: https://issues.apache.org/jira/browse/OAK-5079
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: documentmk
>            Reporter: Chetan Mehrotra
>            Assignee: Chetan Mehrotra
>             Fix For: 1.6
>
>         Attachments: OAK-5079-v1.diff
>
>
> DocumentNodeState.diff logic relies on fact that all child nodes for any 
> given path are represented as NodeDocument. This would not work if we have 
> bundled child nodes.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to