[
https://issues.apache.org/jira/browse/OAK-5092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15667027#comment-15667027
]
Michael Dürig commented on OAK-5092:
------------------------------------
bq. mainly sampling rather than actual math
Which I agree is probably the best method we have here. Could this actually be
codified somehow? So if we ever have to tweak this again we "just run this
utility". For now this could be as simple as a @Ignored test with some Javadoc
stating its purpose.
bq. platform dependent
This *is* a concern. Do we know how different those platforms are? Which
platform did you tweak the current weights for? I think we need at least keep
an eye on this.
Taking above idea of codifying further, we might think of creating an utility a
for tweaking these weights so the "customer" could run this on his platform
prior go-live. Just an idea for now though...
bq. at the same time the numbers are a bit confusing
Agreed. We could reset those statistics every time a generation is purged. This
would mitigate the confusion a bit. OTOH,
{{CacheStatsMBean#getEvictionCount()}} apparently also does not contain all
evictions per its Javadoc. So above equation might not always hold even with
other more regular caches. I think we should solve this through documentation.
If you tweak low level caches you need to know what you are doing anyway.
> Add support for weighing the cache entries in caches
> ----------------------------------------------------
>
> Key: OAK-5092
> URL: https://issues.apache.org/jira/browse/OAK-5092
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: segment-tar
> Reporter: Alex Parvulescu
> Assignee: Alex Parvulescu
> Priority: Minor
> Fix For: 1.6, 1.5.15
>
> Attachments: OAK-5092.patch
>
>
> Some of the current caches in {{segment-tar}} don't have support for
> evaluation of current weight. I'd like to look into the {{PriorityCache}} and
> {{RecordCache}} we use and possibly add something. this is based on initial
> patch from OAK-4966.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
