[ https://issues.apache.org/jira/browse/OAK-4940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15681366#comment-15681366 ]
Chetan Mehrotra commented on OAK-4940: -------------------------------------- bq. I've now chosen two separate sets (parent and all) as that allows for slightly more precise filtering (and the set should still be small, so no large overhead expected) +1 Makes sense. Lets treat them distinctly > Consider collecting grand-parent changes in ChangeSet > ----------------------------------------------------- > > Key: OAK-4940 > URL: https://issues.apache.org/jira/browse/OAK-4940 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: core > Affects Versions: 1.5.12 > Reporter: Stefan Egli > Assignee: Stefan Egli > Fix For: 1.6, 1.5.14 > > Attachments: OAK-4940.patch > > > At the moment the ChangeSet, which is populated by ChangeCollectorProvider (a > Validator) during a commit, collects changed property names, as well as node > name, node type and path of the parent (whereas _parent_ for a property > change is its node, while for a node change is actually its parent). > For improvements such as SLING-6163 it might be valuable to collect > grand-parent changes (node name, node type and perhaps path) too. We could > extend the ChangeSet with additional, explicit grand-parent sets (ie we > should not mix them with the parent changes as that would lessen filtering > rate) -- This message was sent by Atlassian JIRA (v6.3.4#6332)