[ https://issues.apache.org/jira/browse/OAK-5121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15695597#comment-15695597 ]
Stefan Egli commented on OAK-5121: ---------------------------------- [~chetanm] I thought perhaps we can make it more explicit in the BackgroundObserver that on overflow it is not really an external CommitInfo, but perhaps an _overflow_ CommitInfo - which 'looks like an external' one but in the code we could distinguish this internally to the BackgroundObserver. I think that's what I had in mind with this ticket. But other than that yes, merging the ChangeSets for all the overflowing changes is required. > review CommitInfo==null in BackgroundObserver with isExternal change > -------------------------------------------------------------------- > > Key: OAK-5121 > URL: https://issues.apache.org/jira/browse/OAK-5121 > Project: Jackrabbit Oak > Issue Type: Task > Components: core > Affects Versions: 1.5.13 > Reporter: Stefan Egli > Assignee: Stefan Egli > Fix For: 1.6 > > > OAK-4898 changes CommitInfo to be never null. This is the case outside of the > BackgroundObserver - but in the BackgroundObserver itself it is explicitly > set to null when compacting. > Once OAK-4898 is committed this task is about reviewing the implications in > BackgroundObserver wrt compaction and CommitInfo==null -- This message was sent by Atlassian JIRA (v6.3.4#6332)