[
https://issues.apache.org/jira/browse/OAK-5160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15704786#comment-15704786
]
Stefan Egli commented on OAK-5160:
----------------------------------
Good points, title updated,
bq. Is there a specific reason why the patch comments out some of the expected
Pairs?
not really, guess it's better to just remove them.
bq. after this change, FilteringAwareObserver implementations can be updated
Good catch, will adjust ChangeProcessor's contentChanged (in this same ticket).
> guarantee before of FilteringAwareObserver.contentChanged to be Nonnull
> -----------------------------------------------------------------------
>
> Key: OAK-5160
> URL: https://issues.apache.org/jira/browse/OAK-5160
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: core
> Affects Versions: 1.5.14
> Reporter: Stefan Egli
> Assignee: Stefan Egli
> Fix For: 1.6, 1.5.15
>
> Attachments: OAK-5160.patch
>
>
> FilteringAwareObserver (and thus ChangeProcessor)'s {{contentChanged}} has
> {{@Nonnull}} for the {{before}} parameter. But for the very first
> contentChanged (at initialization time) this can actually be null. So we
> should change that to {{@Nullable}} there.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
