[ 
https://issues.apache.org/jira/browse/OAK-5125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15723208#comment-15723208
 ] 

Manfred Baedke edited comment on OAK-5125 at 12/5/16 8:51 PM:
--------------------------------------------------------------

Fixed in trunk : http://svn.apache.org/r1772768
Merged into 1.4:  http://svn.apache.org/r1772798

I'd like to add unit tests, but the tests would produce OOMs with the current 
settings, because we'd need something like 8g heap.


was (Author: baedke):
Fixed in trunk : http://svn.apache.org/r1772768.

I'd like to add unit tests, but the tests would produce OOMs with the current 
settings, because we'd need something like 8g heap.

> Some implementations of CacheValue.getMemory() don't care about integer 
> overflow.
> ---------------------------------------------------------------------------------
>
>                 Key: OAK-5125
>                 URL: https://issues.apache.org/jira/browse/OAK-5125
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 1.0.34, 1.2.21, 1.5.13, 1.4.10
>            Reporter: Manfred Baedke
>            Assignee: Manfred Baedke
>            Priority: Blocker
>              Labels: candidate_oak_1_0, candidate_oak_1_2
>             Fix For: 1.6, 1.4.11
>
>
> The interface method org.apache.jackrabbit.oak.cache.CacheValue.getMemory() 
> returns an int value, while some implementations measure values larger than 
> Integer.MAX_VALUE, producing an int overflow. This actually breaks in real 
> life when testing with huge repos and machines, since it's used to measure 
> the size of local diffs (e.g. a reindexing may diff the whole repo against an 
> empty root).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to