[
https://issues.apache.org/jira/browse/OAK-4696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15811892#comment-15811892
]
Manfred Baedke edited comment on OAK-4696 at 1/9/17 2:26 PM:
-------------------------------------------------------------
1.4: r1777971
1.2: r1777972
was (Author: baedke):
1.4: r1777971
> Improve logging for SyncHandler
> -------------------------------
>
> Key: OAK-4696
> URL: https://issues.apache.org/jira/browse/OAK-4696
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: auth-external
> Affects Versions: 1.5.8
> Reporter: Konrad Windszus
> Assignee: Manfred Baedke
> Labels: candidate_oak_1_2
> Fix For: 1.5.14, 1.4.12
>
>
> In the {{ExternalLoginModule.syncUser}} the {{context.sync(..)}} is being
> called without evaluating the return value at all
> (https://github.com/apache/jackrabbit-oak/blob/trunk/oak-auth-external/src/main/java/org/apache/jackrabbit/oak/spi/security/authentication/external/impl/ExternalLoginModule.java#L354).
> The return value should be logged to find out, which sync took place.
> Also I am wondering if it would make sense to do the {{root.commit()}} only
> conditionally in case the return value is not {{SyncResult.NOP}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
