[ https://issues.apache.org/jira/browse/OAK-5557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15848457#comment-15848457 ]
Stefan Egli edited comment on OAK-5557 at 2/1/17 2:57 PM: ---------------------------------------------------------- I'd argue that in case of a branch commit {{diffManyChildren}} is broken - as it does not take {{purge()s}} into account and assumes it can take the timestamps of {{fromRev}}/{{toRev}} - but based on the test case this seems broken. was (Author: egli): I'd argue that in case of a branch commit {{diffManyChildren}} is broken - as it does not take {{purge()}}s into account and assumes it can take the timestamps of {{fromRev}}/{{toRev}} - but based on the test case this seems broken. > incomplete diffManyChildren during commitHook evaluation in a persisted branch > ------------------------------------------------------------------------------ > > Key: OAK-5557 > URL: https://issues.apache.org/jira/browse/OAK-5557 > Project: Jackrabbit Oak > Issue Type: Bug > Affects Versions: 1.2.14, 1.2.23 > Environment: 'easily' reproducible on 1.2.14 > 'takes longer to' reproduce on 1.2.23 > Reporter: Stefan Egli > Assignee: Stefan Egli > Attachments: DocumentNodeStoreBranchesTest.java, > DocumentNodeStoreBranchesTest.java > > > In oak 1.2 when doing a diffManyChildren as part of running the CommitHooks > as part of a branch commit, not all child paths are taken into account in > some cases. > The problem seems to be related to the [{{_modified}} > calculation|https://github.com/apache/jackrabbit-oak/blob/jackrabbit-oak-1.2.14/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentNodeStore.java#L2242] > when doing the query for affected child paths. It seems [that > {{minValue}}|https://github.com/apache/jackrabbit-oak/blob/jackrabbit-oak-1.2.14/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentNodeStore.java#L2242] > is not correctly calculated when doing {{compareAgainstBaseState}} as part > of a persisted branch. > Note that the problem can be reproduced very good on 1.2.14, less good but > still on the latest 1.2 and not in trunk (ie almost 1.6.0). > Attaching a test case to reproduce -- This message was sent by Atlassian JIRA (v6.3.15#6346)