[ https://issues.apache.org/jira/browse/OAK-5229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15859734#comment-15859734 ]
Alex Parvulescu commented on OAK-5229: -------------------------------------- attaching new version of the patch [^OAK-5229-v4.patch]. I implemented Angela's suggestion for cleanup of the node once the primary type is changed. The interesting part is that the provided test does not work anymore in the way it was designed (I updated the test in the patch as an example). With the new purge strategy the node that has its type changed will delete illegal child nodes so it becomes a legal structure. Here we could probably change the test to use a different node type that has some required properties so the save call still fails as before, but I'm first interested in feedback. > Using Node.setPrimaryType() should fail if non-matching childnodes > ------------------------------------------------------------------ > > Key: OAK-5229 > URL: https://issues.apache.org/jira/browse/OAK-5229 > Project: Jackrabbit Oak > Issue Type: Bug > Components: core > Affects Versions: 1.5.14 > Reporter: Tobias Bocanegra > Assignee: Alex Parvulescu > Priority: Critical > Fix For: 1.8, 1.6.1 > > Attachments: OAK-5229.patch, OAK-5229-tests.patch, OAK-5229-v2.patch, > OAK-5229-v3.patch, OAK-5229-v4.patch > > > 1. Assume the following: > {noformat} > /testNode [nt:unstructured] > /unstructured_child [nt:unstructured] > {noformat} > 2. setting "/testNode".setPrimaryType("nt:folder") > 3. save the session. > Altering the primary type works, thus leaving the repository in an > inconsistent state. > Interestingly, subsequent calls to > "/testNiode/unstructured_child".setProperty() will fail: > {noformat} > javax.jcr.nodetype.ConstraintViolationException: OakConstraint0001: > /test_node[[nt:folder]]: No matching definition found for child node > unstructured_child with effective type [nt:unstructured] > {noformat} -- This message was sent by Atlassian JIRA (v6.3.15#6346)