[ https://issues.apache.org/jira/browse/OAK-5623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15860939#comment-15860939 ]
Alex Parvulescu commented on OAK-5623: -------------------------------------- patch looks good to me. but {{oak-auth-ldap}} is failing to meet the coverage requirements (standing at 0.73 on my local). {noformat} [INFO] --- jacoco-maven-plugin:0.7.1.201405082137:check (default-check) @ oak-auth-ldap --- [INFO] Analyzed bundle 'Oak LDAP Authentication Support' with 16 classes [WARNING] Rule violated for bundle Oak LDAP Authentication Support: lines covered ratio is 0.73, but expected minimum is 0.75 [ERROR] Failed to execute goal org.jacoco:jacoco-maven-plugin:0.7.1.201405082137:check (default-check) on project oak-auth-ldap: Coverage checks have not been met. See log for details. -> [Help 1] {noformat} > Enforce minimum line coverage for security related modules > ---------------------------------------------------------- > > Key: OAK-5623 > URL: https://issues.apache.org/jira/browse/OAK-5623 > Project: Jackrabbit Oak > Issue Type: Task > Components: auth-external, auth-ldap, authorization-cug, parent > Reporter: angela > Assignee: angela > Fix For: 1.7.0 > > Attachments: OAK-5623.patch > > > I would like to use jacoco-maven-plugin to run an additional verification > upon module build to make sure the line coverage with test cases is > maintained while evolving the source. > The attached patch extends the existing plugin definition for > jacoco-maven-plugin in the parent pom.xml and enables the verification with > the following modules: > - auth-external > - auth-ldap > - authorization-cug > Since the patch modifies the parent pom.xml I would like others to review > this as well. Will send out notification to the list. -- This message was sent by Atlassian JIRA (v6.3.15#6346)