[ 
https://issues.apache.org/jira/browse/OAK-5600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15882769#comment-15882769
 ] 

Michael Dürig commented on OAK-5600:
------------------------------------

Test case looks good. 

Thinking about edge cases: how does the consistency checker behave if no filter 
paths is given? Is this reasonable or should we prevent it at all?

> Test coverage for CheckCommand
> ------------------------------
>
>                 Key: OAK-5600
>                 URL: https://issues.apache.org/jira/browse/OAK-5600
>             Project: Jackrabbit Oak
>          Issue Type: Task
>          Components: run, segment-tar
>            Reporter: Andrei Dulceanu
>            Assignee: Andrei Dulceanu
>            Priority: Minor
>              Labels: tooling
>             Fix For: 1.7.0, 1.8
>
>         Attachments: OAK-5600-02.patch, OAK-5600-03.patch, OAK-5600-04.patch, 
> OAK-5600.patch
>
>
> We should add tests for {{o.a.j.o.r.CheckCommand}} in order to validate 
> recent changes introduced by adding/removing options and their arguments (see 
> OAK-5275, OAK-5276, OAK-5277, OAK-5595). There is also a new feature 
> introduced by OAK-5556 (filter paths) and a refactoring in OAK-5620 which 
> must be thoroughly tested in order to avoid regressions.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to