[
https://issues.apache.org/jira/browse/OAK-5876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15899201#comment-15899201
]
Marcel Reutegger commented on OAK-5876:
---------------------------------------
+1 looks good to me.
> SplitDocumentCleanup should implement Closeable
> -----------------------------------------------
>
> Key: OAK-5876
> URL: https://issues.apache.org/jira/browse/OAK-5876
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: documentmk
> Reporter: Julian Reschke
> Assignee: Julian Reschke
> Labels: candidate_oak_1_0, candidate_oak_1_2, candidate_oak_1_4,
> candidate_oak_1_6
> Fix For: 1.7.0, 1.8
>
> Attachments: OAK-5876.diff
>
>
> {{SplitDocumentCleanup}} currently does not close the {{Iterable}} holding
> {{splitDocGarbage}}. It should implement {{Closeable}} and forward calls to
> {{close()}} to the {{Iterable}}, if that happens to be {{Closeable}}.
> Likewise, {{VersionGCSupport}} should call {{close()}} on
> {{SplitDocumentCleanup}} when done.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
