[ 
https://issues.apache.org/jira/browse/OAK-6020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15972813#comment-15972813
 ] 

angela edited comment on OAK-6020 at 4/18/17 3:37 PM:
------------------------------------------------------

[~reschke], in the light of OAK-6069 we made some effort to get rid of the 
_org.apache.jackrabbit.oak.util_ package in {{oak-core}}. would there be an 
alternative place to put this utility? maybe some 
_org.apache.jackrabbt.oak.commons_ package space in {{oak-commons}}? or must 
{{TimeDurationFormatter}} not be used outside of the scope of {{oak-core}}?


was (Author: anchela):
[~reschke], in the light of OAK-6069 we made some effort to get rid of the 
_org.apache.jackrabbit.oak.util_ package in {{oak-core}}. would there be an 
alternative place to put this utility? maybe some 
_org.apache.jackrabbt.oak.commons_ package space in {{oak-commons}}? or must 
{{TimeDurationFormatterTest}} not be used outside of the scope of {{oak-core}}?

> add a Guava Stopwatch like duration formatter
> ---------------------------------------------
>
>                 Key: OAK-6020
>                 URL: https://issues.apache.org/jira/browse/OAK-6020
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: commons
>            Reporter: Julian Reschke
>            Assignee: Julian Reschke
>            Priority: Minor
>              Labels: candidate_oak_1_0, candidate_oak_1_2, candidate_oak_1_4, 
> candidate_oak_1_6
>             Fix For: 1.7.0, 1.8
>
>         Attachments: OAK-6020.diff
>
>
> The duration formatter in {{com.google.common.base.Stopwatch}} can only be 
> used when we indeed have a {{Stopwatch}} object, which is not always the case.
> {{org.apache.jackrabbit.oak.management.ManagementOperation}} has similar code 
> already.
> Proposal: move that code into a separate generic class.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to