[
https://issues.apache.org/jira/browse/OAK-6102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15975870#comment-15975870
]
Tobias Bocanegra edited comment on OAK-6102 at 4/20/17 1:12 AM:
----------------------------------------------------------------
the extra filter is used in
{{listUsers()}} / {{listGroups()}} via the internal {{getEntryIterator()}}
and in
{{getUser()}} / {{getGroup()}} via {{getEntry()}} via {{getSearchFilter()}}
since those methods use the userId or groupId to find the ldap entry based on
the filters.
but the {{LdapIdentityProvider#getIdentity(ExternalIdentityRef)}} uses the
{{ExternalIdentityRef#getId}} which is the DN for the LDAP case. So no
filtering applies here.
was (Author: tripod):
the extra filter is used in
{{listUsers()}}
{{listGroups()}}
via the internal {{getEntryIterator()}}
and in
{{getUser()}} / {{getGroup()}} via {{getEntry()}} via {{getSearchFilter()}}
since those methods use the userId or groupId to find the ldap entry based on
the filters.
but the {{LdapIdentityProvider#getIdentity(ExternalIdentityRef)}} uses the
{{ExternalIdentityRef#getId}} which is the DN for the LDAP case. So no
filtering applies here.
> LdapIdentityProvider#getIdentity(ExternalIdentityRef) and
> LdapIdentityProvider#getUser(String) should behave consistently.
> --------------------------------------------------------------------------------------------------------------------------
>
> Key: OAK-6102
> URL: https://issues.apache.org/jira/browse/OAK-6102
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: auth-external
> Affects Versions: 1.4.15, 1.6.1, 1.0.38, 1.2.25
> Reporter: Manfred Baedke
> Assignee: Manfred Baedke
> Priority: Minor
>
> The method LdapIdentityProvider#getIdentity(ExternalIdentityRef) doesn't use
> the configurable user.extrafilter, while LdapIdentityProvider#getUser(String)
> does. The latter behavior is correct and should also be implemented by
> #getIdentity(ExternalIdentityRef).
> (cc [~anchela], [~tripod])
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
