[ https://issues.apache.org/jira/browse/OAK-6106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15982532#comment-15982532 ]
Michael Dürig commented on OAK-6106: ------------------------------------ Benchmarks: {code} # ConcurrentReadTest C min 10% 50% 90% max N Oak-Segment-Tar w/o r1792030 1 26 86 107 133 289 1656 Oak-Segment-Tar w r1792030 1 102 175 251 303 435 729 {code} > Excessive memory usage by the cached segment references > ------------------------------------------------------- > > Key: OAK-6106 > URL: https://issues.apache.org/jira/browse/OAK-6106 > Project: Jackrabbit Oak > Issue Type: Bug > Components: segment-tar > Reporter: Michael Dürig > Assignee: Michael Dürig > Labels: perfomance > Fix For: 1.7.0, 1.8 > > Attachments: OAK-6106.patch > > > The references of a segment to other segments are cached within > {{Segment.readReferencedSegments()}}. However caching the {{SegmentId}} > instances themselves leads to excessive heap usage as each id also keeps a > reference to its underlying segment. > I suggest to cache those references as msb, lsb pairs instead and create the > {{SegmentId}} instance on the fly when required. -- This message was sent by Atlassian JIRA (v6.3.15#6346)