[
https://issues.apache.org/jira/browse/OAK-2808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16028740#comment-16028740
]
Chetan Mehrotra edited comment on OAK-2808 at 5/30/17 4:49 AM:
---------------------------------------------------------------
{noformat}
+ if (property != null) {
+ if (property.getType() == BINARIES || property.getType() ==
BINARY) {
+ for (Blob b : property.getValue(BINARIES)) {
+ blobDeletionCallback.deleted(b.toString(),
+ Lists.newArrayList(definition.getIndexPath(),
dataNodeName, name));
+ }
+ }
+ }
{noformat}
* b.toString()- Do not rely on toString and instead make use of
Blob#contentIdentity. If not null the use that ([~amitj_76] thoughts?)
* BlobDeletionCallback#deleted(String blobId, Iterable<String> ids) - Some docs
around what the parameters mean here and what are they used for. To me the
second param appears to be the file node path and in that case we just pass the
whole path. Logic can later interpret the path segements like last segment as
file node name, second last as data node name etc
was (Author: chetanm):
{noformat}
+ if (property != null) {
+ if (property.getType() == BINARIES || property.getType() ==
BINARY) {
+ for (Blob b : property.getValue(BINARIES)) {
+ blobDeletionCallback.deleted(b.toString(),
+ Lists.newArrayList(definition.getIndexPath(),
dataNodeName, name));
+ }
+ }
+ }
{noformat}
* b.toString()- Do not rely on toString and instead make use of
Blob#contentIdentity. If not null the use that
* BlobDeletionCallback#deleted(String blobId, Iterable<String> ids) - Some docs
around what the parameters mean here and what are they used for. To me the
second param appears to be the file node path and in that case we just pass the
whole path. Logic can later interpret the path segements like last segment as
file node name, second last as data node name etc
> Active deletion of 'deleted' Lucene index files from DataStore without
> relying on full scale Blob GC
> ----------------------------------------------------------------------------------------------------
>
> Key: OAK-2808
> URL: https://issues.apache.org/jira/browse/OAK-2808
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: lucene
> Reporter: Chetan Mehrotra
> Assignee: Vikas Saurabh
> Labels: datastore, performance
> Fix For: 1.8
>
> Attachments: copyonread-stats.png, OAK-2808-1.patch
>
>
> With storing of Lucene index files within DataStore our usage pattern
> of DataStore has changed between JR2 and Oak.
> With JR2 the writes were mostly application based i.e. if application
> stores a pdf/image file then that would be stored in DataStore. JR2 by
> default would not write stuff to DataStore. Further in deployment
> where large number of binary content is present then systems tend to
> share the DataStore to avoid duplication of storage. In such cases
> running Blob GC is a non trivial task as it involves a manual step and
> coordination across multiple deployments. Due to this systems tend to
> delay frequency of GC
> Now with Oak apart from application the Oak system itself *actively*
> uses the DataStore to store the index files for Lucene and there the
> churn might be much higher i.e. frequency of creation and deletion of
> index file is lot higher. This would accelerate the rate of garbage
> generation and thus put lot more pressure on the DataStore storage
> requirements.
> Discussion thread http://markmail.org/thread/iybd3eq2bh372zrl
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
