[
https://issues.apache.org/jira/browse/OAK-6295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16040508#comment-16040508
]
Tommaso Teofili commented on OAK-6295:
--------------------------------------
late +1, thanks Angela!
> Move constants from oak.query.QueryImpl to oak.spi.query.QueryConstants
> -----------------------------------------------------------------------
>
> Key: OAK-6295
> URL: https://issues.apache.org/jira/browse/OAK-6295
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: core, query
> Reporter: angela
> Fix For: 1.8, 1.7.2
>
> Attachments: OAK-6295.patch
>
>
> in the light of the modularisation effort i had a look at the query code and
> noticed that the constants defined on {{QueryImpl}} are needed outside of the
> scope of the query implementation.
> IMO that indicates that those constants are of broader use and might better
> be located at {{oak.spi.query.QueryConstants}}. moving would in fact remove
> all imports of {{QueryImpl}} in the _oak-lucene_ module.
> [~tmueller], [~teofili], it will attach a proposed patch for this improvement
> and would appreciate if you could review if you are ok with that change.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
