[ 
https://issues.apache.org/jira/browse/OAK-6375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16055828#comment-16055828
 ] 

Chetan Mehrotra commented on OAK-6375:
--------------------------------------

bq. Maybe we can modify the WhiteboardUtils#registerMBean() method, so it adds 
all the passed attributes to jmx.objectname AND uses them for the whiteboard 
register() method as well?

+1. Similar approach is used for scheduled jobs (OAK-5097)

> RevisionGCMbeans are not filtered correctly in the RepositoryManagement
> -----------------------------------------------------------------------
>
>                 Key: OAK-6375
>                 URL: https://issues.apache.org/jira/browse/OAK-6375
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 1.7.3
>            Reporter: Tomek Rękawek
>            Assignee: Tomek Rękawek
>             Fix For: 1.8, 1.7.4
>
>
> The RepositoryManagement uses the new Whiteboard#track(Class,Map) method to 
> get services with given role. When the OSGi implementation of the whiteboard 
> is being used, the filter is transformed into OSGi filter expression. 
> Particularly, the {{role}} property is being used to get the RevisionGCMBean 
> of the right type.
> However, the RevisionGCMBean role is being set as a part of the 
> {{jmx.objectname}} property, not a separate property. The {{jmx.objectname}} 
> property has following form:
> {noformat}
> org.apache.jackrabbit.oak:name=Revision garbage collection - 
> secondary,type=RevisionGarbageCollection,role=secondary
> {noformat}
> Because of that, an attempt to call the 
> RepositoryManagement#startRevisionGC() method (or its parametrized version) 
> fails.
> //cc: [~chetanm], [~mduerig]



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to