[ https://issues.apache.org/jira/browse/OAK-6790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16196838#comment-16196838 ]
Vikas Saurabh edited comment on OAK-6790 at 10/9/17 11:54 AM: -------------------------------------------------------------- [~teofili], yes, I realized that the package export is breaking backward comatibility - I was assuming that we've done this for a lot other packages and felt that it might be ok here too. I feel if we're ok to move it to a separate bundle (to me query-spi feels better home), then we might be ok with package update too. was (Author: catholicon): [~teofili], yes, I realized that the package export is breaking backward in comatibility - I was assuming that we've done this for a lot other packages and felt that it might be ok here too. I feel if we're ok to move it to a separate bundle (to me query-spi feels better home), then we might be ok with package update too. > FacetResult class isn't exposed anymore > --------------------------------------- > > Key: OAK-6790 > URL: https://issues.apache.org/jira/browse/OAK-6790 > Project: Jackrabbit Oak > Issue Type: Bug > Components: query > Affects Versions: 1.7.2 > Reporter: Vikas Saurabh > Assignee: Vikas Saurabh > Fix For: 1.8 > > > OAK-3847 exposed {{FacetResult}} (rather > {{org.apache.jackrabbit.oak.query.facet}} package) to easily consume > extracted facet data. That exported package got removed during OAK-6304 (as > noted in this comment \[1]). > We need to export that class - maybe that class makes sense as part of > {{oak-query-spi}} module - that still needs to be checked as assessed btw (ie > if we can simply re-enable the removed export AND that its current place in > oak-core still makes sense or not). > [~anchela], would you remember what was the warning that was observed without > removing this export (disclaimer: I still feel that it belongs in > {{oak-query-spi}}... I'm just trying to have all data available). > \[1]: > https://issues.apache.org/jira/browse/OAK-6304?focusedCommentId=16042721&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16042721 -- This message was sent by Atlassian JIRA (v6.4.14#64029)