[ 
https://issues.apache.org/jira/browse/OAK-6790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16198195#comment-16198195
 ] 

Chetan Mehrotra commented on OAK-6790:
--------------------------------------

bq. I'm guessing consumer of this class would have to mark dependency on 
oak-query-spi anyway

Not necessarily as his code would still compile fine with older maven 
dependency however his existing working app would not work post upgrade as his 
bundle using the older FacetResult would not resolve

> FacetResult class isn't exposed anymore
> ---------------------------------------
>
>                 Key: OAK-6790
>                 URL: https://issues.apache.org/jira/browse/OAK-6790
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: query
>    Affects Versions: 1.7.2
>            Reporter: Vikas Saurabh
>            Assignee: Vikas Saurabh
>             Fix For: 1.8, 1.7.10
>
>
> OAK-3847 exposed {{FacetResult}} (rather 
> {{org.apache.jackrabbit.oak.query.facet}} package) to easily consume 
> extracted facet data. That exported package got removed during OAK-6304 (as 
> noted in this comment \[1]).
> We need to export that class - maybe that class makes sense as part of 
> {{oak-query-spi}} module - that still needs to be checked as assessed btw (ie 
> if we can simply re-enable the removed export AND that its current place in 
> oak-core still makes sense or not).
> [~anchela], would you remember what was the warning that was observed without 
> removing this export (disclaimer: I still feel that it belongs in 
> {{oak-query-spi}}... I'm just trying to have all data available).
> \[1]: 
> https://issues.apache.org/jira/browse/OAK-6304?focusedCommentId=16042721&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16042721



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to