[ https://issues.apache.org/jira/browse/OAK-6915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16249258#comment-16249258 ]
Francesco Mari commented on OAK-6915: ------------------------------------- I could have a look at the patch just now. The patch looks good to me, and the comment is clear and explanatory. > Minimize the amount of uncached segment reads > --------------------------------------------- > > Key: OAK-6915 > URL: https://issues.apache.org/jira/browse/OAK-6915 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: segment-tar > Reporter: Francesco Mari > Assignee: Francesco Mari > Fix For: 1.8, 1.7.12 > > Attachments: OAK-6915-01.patch, OAK-6915-02.patch, OAK-6915-03.patch, > OAK-6915-04.patch, OAK-6915-05.patch, OAK-6915-diagnostics-02.patch, > OAK-6915-diagnostics.patch, OAK-6915.patch, Screen Shot 2017-11-09 at > 14.14.28.png, Screen Shot 2017-11-09 at 14.16.59.png > > > The current implementation of {{SegmentCache}} should make better use of the > underlying Guava cache by relying on the cached segments instead of > unconditionally performing an uncached segment read via the > {{Callable<Segment>}} passed to {{SegmentCache#getSegment}}. -- This message was sent by Atlassian JIRA (v6.4.14#64029)