[ https://issues.apache.org/jira/browse/OAK-7203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16346629#comment-16346629 ]
Alex Deparvu commented on OAK-7203: ----------------------------------- bq. bind/unbind removed additionally could you explain why this is needed? To me the test code now looks pretty ugly: catch an IllegalAccessException to wrap it into a RuntimeException? The current design: * field is set to default so it has a value outside OSGi (tests & other setups), if needed one can change it by calling *bind * field is set via OSGi in which case unbind will also be called so the reference needs to be set to _null_ for consistency, _not the default value_, as we are not in the default case anymore To me this seems to cover both OSGi and non-OSGi cases but the current code has one issue: the reference is mandatory. We can just add the required tag to the reference and be done. Why all the extra changes? > Make MountInfoProvider service in AuthorizationConfigurationImpl optional > ------------------------------------------------------------------------- > > Key: OAK-7203 > URL: https://issues.apache.org/jira/browse/OAK-7203 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: authorization-cug, core > Affects Versions: 1.8.1 > Reporter: Oliver Lietz > Priority: Major > Attachments: OAK-7203.patch > > > While testing Sling with Oak 1.8 I've observed that > AuthorizationConfigurationImpl gets not activated due to missingĀ > MountInfoProvider service: > {noformat} > @Reference > private MountInfoProvider mountInfoProvider = > Mounts.defaultMountInfoProvider(); > {noformat} > {noformat} > org.apache.jackrabbit.oak.security.authorization.AuthorizationConfigurationImpl > Bundle org.apache.jackrabbit.oak-core (63) > Implementation Class > org.apache.jackrabbit.oak.security.authorization.AuthorizationConfigurationImpl > Default State enabled > Activation delayed > Configuration Policy optional > Service Type singleton > Services > org.apache.jackrabbit.oak.spi.security.authorization.AuthorizationConfiguration > org.apache.jackrabbit.oak.spi.security.SecurityConfiguration > PID > org.apache.jackrabbit.oak.security.authorization.AuthorizationConfigurationImpl > Reference mountInfoProvider Unsatisfied > Service Name: org.apache.jackrabbit.oak.spi.mount.MountInfoProvider > Cardinality: 1..1 > Policy: static > Policy Option: reluctant > No Services bound > Properties component.id = 35 > component.name = > org.apache.jackrabbit.oak.security.authorization.AuthorizationConfigurationImpl > configurationRanking = 100 > importBehavior = abort > oak.security.name = > org.apache.jackrabbit.oak.security.authorization.AuthorizationConfigurationImpl > readPaths = [/jcr:system/rep:namespaces, /jcr:system/jcr:nodeTypes, > /jcr:system/rep:privileges] > {noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005)