[ 
https://issues.apache.org/jira/browse/OAK-7182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16442475#comment-16442475
 ] 

Julian Reschke commented on OAK-7182:
-------------------------------------

[~rombert] - I had a look at your suggestions wrt "<Conditional-Package>".

I tried this with oak-core-spi:
{noformat}
Index: pom.xml
===================================================================
--- pom.xml     (revision 1829432)
+++ pom.xml     (working copy)
@@ -35,10 +35,7 @@
         <artifactId>maven-bundle-plugin</artifactId>
         <configuration>
           <instructions>
-            <Import-Package>
-              <!-- OAK-7182 -->${guava.osgi.import},
-              *
-            </Import-Package>
+            <Conditional-Package>com.google.*</Conditional-Package>
             <Export-Package>
               org.apache.jackrabbit.oak.cache,
               org.apache.jackrabbit.oak.commons.jmx,
{noformat}

As predicted in 
<https://web.archive.org/web/20160708225222/http://njbartlett.name/2014/05/26/static-linking.html>,
 I'm getting warnings as we use Guava APIs in exported method signatures: 
{noformat}
[WARNING] Bundle org.apache.jackrabbit:oak-core-spi:bundle:1.10-SNAPSHOT : 
Export org.apache.jackrabbit.oak.cache,  has 2,  private references 
[com.google.common.cache, com.google.common.collect],
[WARNING] Bundle org.apache.jackrabbit:oak-core-spi:bundle:1.10-SNAPSHOT : 
Export org.apache.jackrabbit.oak.commons.jmx,  has 1,  private references 
[com.google.common.base],
[WARNING] Bundle org.apache.jackrabbit:oak-core-spi:bundle:1.10-SNAPSHOT : 
Export org.apache.jackrabbit.oak.spi.whiteboard,  has 1,  private references 
[com.google.common.base],
{noformat}

Also, JAR file size for oak-core-spi goes up from 152087 to 1950807 (with Guava 
15).

> Make it possible to update Guava
> --------------------------------
>
>                 Key: OAK-7182
>                 URL: https://issues.apache.org/jira/browse/OAK-7182
>             Project: Jackrabbit Oak
>          Issue Type: Wish
>            Reporter: Julian Reschke
>            Assignee: Julian Reschke
>            Priority: Minor
>         Attachments: OAK-7182-guava-21.diff, guava.diff
>
>
> We currently rely on Guava 15, and this affects all users of Oak because they 
> essentially need to use the same version.
> This is an overall issue to investigate what would need to be done in Oak in 
> order to make updates possible.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to