[ https://issues.apache.org/jira/browse/OAK-7878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16697227#comment-16697227 ]
Axel Hanikel commented on OAK-7878: ----------------------------------- [~frm] I've added some tests in [^0001-OAK-7878-Add-more-unit-tests-for-LoggingHook.patch] and I think it covers most positive cases. I can't think of any negative test cases except passing in null values to all the public methods, but that doesn't seem useful to me. > Add unit test for LoggingHook > ----------------------------- > > Key: OAK-7878 > URL: https://issues.apache.org/jira/browse/OAK-7878 > Project: Jackrabbit Oak > Issue Type: Test > Components: segment-tar > Affects Versions: 1.9.10 > Reporter: Axel Hanikel > Assignee: Axel Hanikel > Priority: Minor > Fix For: 1.10 > > Attachments: 0001-OAK-7878-Add-LoggingHookTest.patch, > 0001-OAK-7878-Add-LoggingHookTest.patch, > 0001-OAK-7878-Add-more-unit-tests-for-LoggingHook.patch, OAK-7878-02.patch > > > Add a unit test for LoggingHook. -- This message was sent by Atlassian JIRA (v7.6.3#76005)