[
https://issues.apache.org/jira/browse/OAK-7977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16741904#comment-16741904
]
Tomek Rękawek commented on OAK-7977:
------------------------------------
The patch (which is based on the internal code we were working on) looks fine.
The only thing that I'm wondering about is the PrintWriter - I don't think we
should use it. I think it reduces the SegmentStoreMigrator reusability - now
every time we want to use the SegmentStoreMigrator anywhere in the Oak code, we
need to wonder what kind of logging is used there. Could you describe the
reason why we need to use PrintWriter rather than a standard logger? I guess it
have something to do with the standalone tools - but then, can't we have a
custom logger configuration that outputs the logs in the format desired by the
tool?
> Add multi-threaded segment transfer to oak-run segment-copy
> -----------------------------------------------------------
>
> Key: OAK-7977
> URL: https://issues.apache.org/jira/browse/OAK-7977
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: oak-run, segment-azure
> Reporter: Andrei Dulceanu
> Assignee: Andrei Dulceanu
> Priority: Minor
> Labels: tooling
> Fix For: 1.12
>
> Attachments: OAK-7977.patch
>
>
> The transfer of segments between different persistence types when using
> {{oak-run segment-copy}} can be sped up by employing multiple threads in the
> transfer. The idea is to try to load {{n}} segments from the source, which
> are then consumed by the writer on the target, keeping the ordering of the
> segments in the process.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
