[ https://issues.apache.org/jira/browse/OAK-7994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16771995#comment-16771995 ]
angela edited comment on OAK-7994 at 2/19/19 3:02 PM: ------------------------------------------------------ [~stillalex], looks very good to me in general... i just have one tiny concern: since {{OakPrincipalManager}} extends from {{PrincipalManager}}, we might under some circumstances run into troubles once we want to move the method over to _jackrabbit-api_. i vaguely remember such issues, when e.g. the return value required adjustment but the name was to stay the same. Regarding sorting: can we mention that in the API contract that this is an implementation detail? was (Author: anchela): [~stillalex], looks very good to me in general... i just have one tiny concern: since {{OakPrincipalManager}} extends from {{PrincipalManager}}, we might under some circumstances run into troubles once we want to move the method over to _jackrabbit-api_. i vaguely remember such issues, when e.g. the return value required adjustment but the name was to stay the same. > Principal Management APIs don't allow for search pagination > ----------------------------------------------------------- > > Key: OAK-7994 > URL: https://issues.apache.org/jira/browse/OAK-7994 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: security, security-spi > Reporter: Alex Deparvu > Assignee: Alex Deparvu > Priority: Major > Attachments: oak-7994.patch > > > Current apis are limited to passing a search token, I'd like to also add > range (offset, limit). -- This message was sent by Atlassian JIRA (v7.6.3#76005)