[ 
https://issues.apache.org/jira/browse/OAK-8233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

bd2019us updated OAK-8233:
--------------------------
    Description: 
Hello,
I found that System.currentTimeMillis() can be used here instead of new 
Date.getTime().
Since new Date() is a thin wrapper of light method System.currentTimeMillis().  
The performance will be greatly damaged if it is invoked too much times.
According to my local testing at the same environment, 
System.currentTimeMillis() can achieve a speedup to 5 times (435 ms vs 2073 
ms), when these two methods are invoked 5,000,000 times.


  was:
Location: 
oak-commons/src/main/java/org/apache/jackrabbit/oak/commons/LongUtils.java:52

Hello,
I found that System.currentTimeMillis() can be used here instead of new 
Date.getTime().
Since new Date() is a thin wrapper of light method System.currentTimeMillis().  
The performance will be greatly damaged if it is invoked too much times.
According to my local testing at the same environment, 
System.currentTimeMillis() can achieve a speedup to 5 times (435 ms vs 2073 
ms), when these two methods are invoked 5,000,000 times.



> new Date.getTime() can be changed to System.currentTimeMillis() to improve 
> performance
> --------------------------------------------------------------------------------------
>
>                 Key: OAK-8233
>                 URL: https://issues.apache.org/jira/browse/OAK-8233
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>            Reporter: bd2019us
>            Priority: Major
>         Attachments: 1.patch
>
>
> Hello,
> I found that System.currentTimeMillis() can be used here instead of new 
> Date.getTime().
> Since new Date() is a thin wrapper of light method 
> System.currentTimeMillis().  The performance will be greatly damaged if it is 
> invoked too much times.
> According to my local testing at the same environment, 
> System.currentTimeMillis() can achieve a speedup to 5 times (435 ms vs 2073 
> ms), when these two methods are invoked 5,000,000 times.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to