[ 
https://issues.apache.org/jira/browse/OAK-8173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16818046#comment-16818046
 ] 

angela edited comment on OAK-8173 at 4/15/19 3:05 PM:
------------------------------------------------------

[~reschke], unfortunately not.... i ran the build on java 8 and 11 but don't 
have a windows machine at hand. i will adjust the numbers such that the build 
passes for you as well. imo the important piece that we may not to change/add a 
lot of code in the security area without adding caring about testing. i don't 
care about the exact numbers.

-> done at revision 1857591 (hope that solves the issue for you)



was (Author: anchela):
[~reschke], unfortunately not.... i ran the build on java 8 and 11 but don't 
have a windows machine at hand. i will adjust the numbers such that the build 
passes for you as well. imo the important piece that we may not to change/add a 
lot of code in the security area without adding caring about testing. i don't 
care about the exact numbers.

> Add branch coverage to Jacoco check
> -----------------------------------
>
>                 Key: OAK-8173
>                 URL: https://issues.apache.org/jira/browse/OAK-8173
>             Project: Jackrabbit Oak
>          Issue Type: Wish
>          Components: auth-external, auth-ldap, authorization-cug, commons, 
> core, parent, security-spi
>            Reporter: angela
>            Assignee: angela
>            Priority: Major
>             Fix For: 1.12.0
>
>         Attachments: OAK-8173.patch
>
>
> i would suggest to add branch coverage extending the existing check for line 
> coverage. note: while the jacoco plugin is defined the parent pom the check 
> is currently disabled by default and thus only affects modules which have it 
> explicitly enabled (i.e. security related modules as well as _oak-core_ and 
> _oak-commons_).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to