[ 
https://issues.apache.org/jira/browse/OAK-8657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16941638#comment-16941638
 ] 

Angela Schreiber commented on OAK-8657:
---------------------------------------

fine with me.

> SimpleCredentialsSupport uses Guava API in exported API
> -------------------------------------------------------
>
>                 Key: OAK-8657
>                 URL: https://issues.apache.org/jira/browse/OAK-8657
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: security-spi
>            Reporter: Julian Reschke
>            Assignee: Julian Reschke
>            Priority: Major
>             Fix For: 1.24.0
>
>
> {noformat}
>     @Override
>     @NotNull
>     public ImmutableSet<Class> getCredentialClasses() {
>         return ImmutableSet.<Class>of(SimpleCredentials.class);
>     }
> {noformat}
> We should fix this to use a regular `Set` (as in the implemented interface). 
> However, this would be an incompatible API change; we could do that in sync 
> with OAK-7358.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to