[
https://issues.apache.org/jira/browse/OAK-8918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17059980#comment-17059980
]
Solomon Rutzky edited comment on OAK-8918 at 3/16/20, 6:27 AM:
---------------------------------------------------------------
While it's probably not a bad thing that this condition is being checked for,
this code really shouldn't even be necessary given the two solutions I noted in
my comment on
[OAK-8908|https://issues.apache.org/jira/browse/OAK-8908?focusedCommentId=17059698&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17059698].
Ideally, the datatype of the two {{ID}} columns would be {{VARBINARY(32)}} (or
even {{BINARY(32)}} if there will always be 32 bytes), thus there is no
collation to deal with. Or, if that's not possible, then at least use a binary
collation in the {{CREATE TABLE}} statements (which will be faster than your
current setup).
Take care,
Solomon...
[https://SqlQuantumLift.com/|https://sqlquantumlift.com/]
[https://SqlQuantumLeap.com/|https://sqlquantumleap.com/]
[https://SQLsharp.com/|https://sqlsharp.com/]
was (Author: solomon.rutzky):
While it's probably not a bad thing that this condition is being checked for,
this code really shouldn't even be necessary given the two solutions I noted in
my comment on OAK-8908. Ideally, the datatype of the two {{ID}} columns would
be {{VARBINARY(32)}} (or even {{BINARY(32)}} if there will always be 32 bytes),
thus there is no collation to deal with. Or, if that's not possible, then at
least use a binary collation in the {{CREATE TABLE}} statements (which will be
faster than your current setup).
Take care,
Solomon...
[https://SqlQuantumLift.com/|https://sqlquantumlift.com/]
[https://SqlQuantumLeap.com/|https://sqlquantumleap.com/]
[https://SQLsharp.com/|https://sqlsharp.com/]
> RDBBlobStore: warn when legacy (SQLServer) default collation is active
> ----------------------------------------------------------------------
>
> Key: OAK-8918
> URL: https://issues.apache.org/jira/browse/OAK-8918
> Project: Jackrabbit Oak
> Issue Type: Technical task
> Components: rdbmk
> Reporter: Julian Reschke
> Assignee: Julian Reschke
> Priority: Minor
> Labels: candidate_oak_1_10
> Fix For: 1.26.0, 1.22.2
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
