[ https://issues.apache.org/jira/browse/OAK-8657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17070950#comment-17070950 ]
Julian Reschke edited comment on OAK-8657 at 4/8/20, 10:01 AM: --------------------------------------------------------------- trunk: [r1876291|http://svn.apache.org/r1876291] [r1875885|http://svn.apache.org/r1875885] [r1875880|http://svn.apache.org/r1875880] was (Author: reschke): trunk: [r1875885|http://svn.apache.org/r1875885] [r1875880|http://svn.apache.org/r1875880] > SimpleCredentialsSupport uses Guava API in exported API > ------------------------------------------------------- > > Key: OAK-8657 > URL: https://issues.apache.org/jira/browse/OAK-8657 > Project: Jackrabbit Oak > Issue Type: Technical task > Components: security-spi > Reporter: Julian Reschke > Assignee: Julian Reschke > Priority: Blocker > Fix For: 1.28.0 > > Attachments: OAK-8657.diff > > > {noformat} > @Override > @NotNull > public ImmutableSet<Class> getCredentialClasses() { > return ImmutableSet.<Class>of(SimpleCredentials.class); > } > {noformat} > We should fix this to use a regular `Set` (as in the implemented interface). > However, this would be an incompatible API change; we could do that in sync > with OAK-7358. -- This message was sent by Atlassian Jira (v8.3.4#803005)