[ 
https://issues.apache.org/jira/browse/OAK-9591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus updated OAK-9591:
---------------------------------
    Description: 
This is useful in the context of FileVault for this algorithm:
 * get the {{NodeDefinition}} of the child node that is to be deleted.
 * loop through all child nodes and count the ones that have the same nodedef. 
{color:#00875a}To compare that the nodedef is same, it was recommended to add 
an equals method in ItemDefinitionImpl as per the conversation done on PR 
[https://github.com/apache/jackrabbit-filevault/pull/163#discussion_r711728698] 
{color}
 * if the nodedef is mandatory and there are more than 1 nodes with this 
nodedef, we can delete it.

  was:
The idea is:
 * get the {{NodeDefinition}} of the child node that is to be deleted.
 * loop through all child nodes and count the ones that have the same nodedef. 
{color:#00875a}To compare that the nodedef is same, it was recommended to add 
an equals method in ItemDefinitionImpl as per the conversation done on PR 
[https://github.com/apache/jackrabbit-filevault/pull/163#discussion_r711728698] 
{color}
 * if the nodedef is mandatory and there are more than 1 nodes with this 
nodedef, we can delete it.


> Implement hashcode() and equals() method in ItemDefinitionImpl
> --------------------------------------------------------------
>
>                 Key: OAK-9591
>                 URL: https://issues.apache.org/jira/browse/OAK-9591
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 1.40.0
>            Reporter: Ankita Agarwal
>            Priority: Major
>             Fix For: 1.42.0
>
>
> This is useful in the context of FileVault for this algorithm:
>  * get the {{NodeDefinition}} of the child node that is to be deleted.
>  * loop through all child nodes and count the ones that have the same 
> nodedef. {color:#00875a}To compare that the nodedef is same, it was 
> recommended to add an equals method in ItemDefinitionImpl as per the 
> conversation done on PR 
> [https://github.com/apache/jackrabbit-filevault/pull/163#discussion_r711728698]
>  {color}
>  * if the nodedef is mandatory and there are more than 1 nodes with this 
> nodedef, we can delete it.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to