[ https://issues.apache.org/jira/browse/OAK-10503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17777675#comment-17777675 ]
Nitin Gupta commented on OAK-10503: ----------------------------------- trunk : [https://github.com/apache/jackrabbit-oak/commit/e904e4594274f28fd7499ec1620648893b43d6b0] , wasn't able to reproduce with a test case, but the fix of not throwing exception is harmless and should work. Keeping this open to try and write the reproducible test case as well. > Incorrect operand in incremental FFS can lead to failure during merge step > -------------------------------------------------------------------------- > > Key: OAK-10503 > URL: https://issues.apache.org/jira/browse/OAK-10503 > Project: Jackrabbit Oak > Issue Type: Task > Reporter: Nitin Gupta > Priority: Major > > There could be a case where a node was moved/renamed which apparently results > the incremental FFS to have 2 entries. > > For example, > NodeA | \{"prop":"value"} > renamed to NodeB | \{"prop":"value"} > > then the incremental FFS has entries - > NodeA | \{"prop":"value"} | D > NodeB | \{"prop":"value"} | M > > The second entry's operand should be A and not M. > The above analysis is an assumption from some observations during some tests > on a large repository. > A more detailed test case needs to be written to investigate this further. > > But the impact of this is that merge for this inc store fails here > [https://jira.corp.adobe.com/browse/GRANITE-48075#:~:text=https%3A//github.com/apache/jackrabbit%2Doak/blob/trunk/oak%2Drun%2Dcommons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/incrementalstore/MergeIncrementalFlatFileStore.java%23L118] > . > > A simple solution could be to treat modification same as addition. -- This message was sent by Atlassian Jira (v8.20.10#820010)