[ 
https://issues.apache.org/jira/browse/OAK-11252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17924441#comment-17924441
 ] 

Stefan Egli commented on OAK-11252:
-----------------------------------

if it's blocking some release then excluding would be feasible. I'm not that 
much in the loop with this code anymore but would advise to at some point 
actually fix those tests instead of excluding (as that would increase coverage).

> flaky BranchCommitGCTest.unmergedRemoveChild
> --------------------------------------------
>
>                 Key: OAK-11252
>                 URL: https://issues.apache.org/jira/browse/OAK-11252
>             Project: Jackrabbit Oak
>          Issue Type: Test
>          Components: documentmk
>            Reporter: Stefan Egli
>            Assignee: Stefan Egli
>            Priority: Major
>
> increased recent flakyness like below:
> {noformat}
> [2024-11-05T23:38:28.210Z] [ERROR] unmergedRemoveChild[17: MongoFixture: 
> MongoDB with 
> ORPHANS_EMPTYPROPS_UNMERGED_BC](org.apache.jackrabbit.oak.plugins.document.BranchCommitGCTest)
>   Time elapsed: 0.024 s  <<< FAILURE!
> [2024-11-05T23:38:28.210Z] java.lang.AssertionError: 
> [2024-11-05T23:38:28.210Z] ORPHANS_EMPTYPROPS_UNMERGED_BC/internalProps - 
> staticStore : Nodes:
> [2024-11-05T23:38:28.210Z] Path: 0:/
> [2024-11-05T23:38:28.210Z] _children=true
> [2024-11-05T23:38:28.210Z] _bc={r192feb1a067-0-1=true}
> [2024-11-05T23:38:28.210Z] _deleted={r192feb1a056-0-1=false}
> [2024-11-05T23:38:28.210Z] _collisions={r192feb1a0a6-0-1=r192feb1a0ad-0-1, 
> r192feb1a09f-0-1=r192feb1a0a6-0-1, r192feb1a098-0-1=r192feb1a09f-0-1, 
> r192feb1a093-0-1=r192feb1a098-0-1}
> [2024-11-05T23:38:28.210Z] _commitRoot={}
> [2024-11-05T23:38:28.210Z] _sweepRev={r0-0-1=r192feb1a071-0-1}
> [2024-11-05T23:38:28.210Z] _revisions={r192feb1a067-0-1=c-r192feb1a071-0-1, 
> r192feb1a056-0-1=c}
> [2024-11-05T23:38:28.210Z] _id=0:/
> [2024-11-05T23:38:28.210Z] _modified=1730849905
> [2024-11-05T23:38:28.210Z] _lastRev={r0-0-1=r192feb1a071-0-1}
> [2024-11-05T23:38:28.210Z] 
> [2024-11-05T23:38:28.210Z] Path: 1:/bar
> [2024-11-05T23:38:28.210Z] _bc={r192feb1a067-0-1=true}
> [2024-11-05T23:38:28.210Z] _deleted={r192feb1a067-0-1=false}
> [2024-11-05T23:38:28.210Z] _commitRoot={r192feb1a067-0-1=0}
> [2024-11-05T23:38:28.210Z] _id=1:/bar
> [2024-11-05T23:38:28.210Z] _modified=1730849905
> [2024-11-05T23:38:28.210Z] 
> [2024-11-05T23:38:28.210Z] Path: 1:/foo
> [2024-11-05T23:38:28.210Z] _bc={r192feb1a067-0-1=true}
> [2024-11-05T23:38:28.210Z] _deleted={r192feb1a067-0-1=false}
> [2024-11-05T23:38:28.210Z] _commitRoot={r192feb1a067-0-1=0}
> [2024-11-05T23:38:28.210Z] _id=1:/foo
> [2024-11-05T23:38:28.210Z] _modified=1730849905
> [2024-11-05T23:38:28.210Z] 
> [2024-11-05T23:38:28.210Z]  expected:<1> but was:<0>
> [2024-11-05T23:38:28.210Z]    at org.junit.Assert.fail(Assert.java:89)
> [2024-11-05T23:38:28.210Z]    at 
> org.junit.Assert.failNotEquals(Assert.java:835)
> [2024-11-05T23:38:28.210Z]    at 
> org.junit.Assert.assertEquals(Assert.java:647)
> [2024-11-05T23:38:28.210Z]    at 
> org.apache.jackrabbit.oak.plugins.document.VersionGarbageCollectorIT.doAssertEquals(VersionGarbageCollectorIT.java:1533)
> [2024-11-05T23:38:28.210Z]    at 
> org.apache.jackrabbit.oak.plugins.document.VersionGarbageCollectorIT.assertStatsCountsEqual(VersionGarbageCollectorIT.java:1518)
> [2024-11-05T23:38:28.210Z]    at 
> org.apache.jackrabbit.oak.plugins.document.BranchCommitGCTest.unmergedRemoveChild(BranchCommitGCTest.java:600)
> [2024-11-05T23:38:28.210Z]    at 
> jdk.internal.reflect.GeneratedMethodAccessor219.invoke(Unknown Source)
> [2024-11-05T23:38:28.210Z]    at 
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> [2024-11-05T23:38:28.210Z]    at 
> java.base/java.lang.reflect.Method.invoke(Method.java:566)
> [2024-11-05T23:38:28.210Z]    at 
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
> [2024-11-05T23:38:28.210Z]    at 
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> [2024-11-05T23:38:28.210Z]    at 
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
> [2024-11-05T23:38:28.210Z]    at 
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
> [2024-11-05T23:38:28.210Z]    at 
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
> [2024-11-05T23:38:28.210Z]    at 
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
> [2024-11-05T23:38:28.211Z]    at 
> org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:54)
> [2024-11-05T23:38:28.211Z]    at 
> org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
> [2024-11-05T23:38:28.211Z]    at 
> org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
> [2024-11-05T23:38:28.211Z]    at 
> org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
> [2024-11-05T23:38:28.211Z]    at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
> [2024-11-05T23:38:28.211Z]    at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)
> [2024-11-05T23:38:28.211Z]    at 
> org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
> [2024-11-05T23:38:28.211Z]    at 
> org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
> [2024-11-05T23:38:28.211Z]    at 
> org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
> [2024-11-05T23:38:28.211Z]    at 
> org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
> [2024-11-05T23:38:28.211Z]    at 
> org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
> [2024-11-05T23:38:28.211Z]    at 
> org.junit.runners.ParentRunner.run(ParentRunner.java:413)
> [2024-11-05T23:38:28.211Z]    at 
> org.junit.runners.Suite.runChild(Suite.java:128)
> [2024-11-05T23:38:28.211Z]    at 
> org.junit.runners.Suite.runChild(Suite.java:27)
> [2024-11-05T23:38:28.211Z]    at 
> org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
> [2024-11-05T23:38:28.211Z]    at 
> org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
> [2024-11-05T23:38:28.211Z]    at 
> org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
> [2024-11-05T23:38:28.211Z]    at 
> org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
> [2024-11-05T23:38:28.211Z]    at 
> org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
> [2024-11-05T23:38:28.211Z]    at 
> org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
> [2024-11-05T23:38:28.211Z]    at 
> org.junit.runners.ParentRunner.run(ParentRunner.java:413)
> [2024-11-05T23:38:28.211Z]    at 
> org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:365)
> [2024-11-05T23:38:28.211Z]    at 
> org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:273)
> [2024-11-05T23:38:28.211Z]    at 
> org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:238)
> [2024-11-05T23:38:28.211Z]    at 
> org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:159)
> [2024-11-05T23:38:28.211Z]    at 
> org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:384)
> [2024-11-05T23:38:28.211Z]    at 
> org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:345)
> [2024-11-05T23:38:28.211Z]    at 
> org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:126)
> [2024-11-05T23:38:28.211Z]    at 
> org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:418)
> {noformat}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to