[ 
https://issues.apache.org/jira/browse/OAK-10304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Manfred Baedke updated OAK-10304:
---------------------------------
    Description: 
Example:
{noformat}
diff --git 
a/oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/RepositoryTest.java 
b/oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/RepositoryTest.java
index f113e4e0d2..7178a36f7f 100644
--- a/oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/RepositoryTest.java
+++ b/oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/RepositoryTest.java
@@ -1996,6 +1996,24 @@ public class RepositoryTest extends 
AbstractRepositoryTest {
         assertFalse(asList(nsReg.getURIs()).contains("file:///foo"));
     }

+    @Test
+    public void testNamespaceNames() throws RepositoryException {
+        NamespaceRegistry nsReg =
+                getAdminSession().getWorkspace().getNamespaceRegistry();
+
+        // valid
+        nsReg.registerNamespace("foo", "https://example.com";);
+        nsReg.unregisterNamespace("foo");
+
+        // invalid
+        try {
+            nsReg.registerNamespace("foo", "example.com");
+            fail("should not register invalid namespace name");
+        } finally {
+            nsReg.unregisterNamespace("foo");
+        }
+    }
{noformat}
Note that names of nodes using invalid namespaces do have an ["expanded 
form"|https://developer.adobe.com/experience-manager/reference-materials/spec/jcr/2.0/3_Repository_Model.html#3.2.5.1%20Expanded%20Form]
 variant that is a legal local name, e.g.
{code:java}
{foo}someLocalName
{code}

  was:
Example:
{noformat}
diff --git 
a/oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/RepositoryTest.java 
b/oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/RepositoryTest.java
index f113e4e0d2..7178a36f7f 100644
--- a/oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/RepositoryTest.java
+++ b/oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/RepositoryTest.java
@@ -1996,6 +1996,24 @@ public class RepositoryTest extends 
AbstractRepositoryTest {
         assertFalse(asList(nsReg.getURIs()).contains("file:///foo"));
     }

+    @Test
+    public void testNamespaceNames() throws RepositoryException {
+        NamespaceRegistry nsReg =
+                getAdminSession().getWorkspace().getNamespaceRegistry();
+
+        // valid
+        nsReg.registerNamespace("foo", "https://example.com";);
+        nsReg.unregisterNamespace("foo");
+
+        // invalid
+        try {
+            nsReg.registerNamespace("foo", "example.com");
+            fail("should not register invalid namespace name");
+        } finally {
+            nsReg.unregisterNamespace("foo");
+        }
+    }
{noformat}
Note that names of nodes using invalid namespaces do have an ["expanded 
form"|https://developer.adobe.com/experience-manager/reference-materials/spec/jcr/2.0/3_Repository_Model.html#3.2.5.1%20Expanded%20Form]
 variant that is a legal local name, e.g.
{code:java}
{foo}someLocalName
{code}
.


> log registration of invalid namespace names
> -------------------------------------------
>
>                 Key: OAK-10304
>                 URL: https://issues.apache.org/jira/browse/OAK-10304
>             Project: Jackrabbit Oak
>          Issue Type: Task
>          Components: core
>            Reporter: Julian Reschke
>            Assignee: Julian Reschke
>            Priority: Major
>             Fix For: 1.54.0, 1.22.17
>
>
> Example:
> {noformat}
> diff --git 
> a/oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/RepositoryTest.java 
> b/oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/RepositoryTest.java
> index f113e4e0d2..7178a36f7f 100644
> --- a/oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/RepositoryTest.java
> +++ b/oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/RepositoryTest.java
> @@ -1996,6 +1996,24 @@ public class RepositoryTest extends 
> AbstractRepositoryTest {
>          assertFalse(asList(nsReg.getURIs()).contains("file:///foo"));
>      }
> +    @Test
> +    public void testNamespaceNames() throws RepositoryException {
> +        NamespaceRegistry nsReg =
> +                getAdminSession().getWorkspace().getNamespaceRegistry();
> +
> +        // valid
> +        nsReg.registerNamespace("foo", "https://example.com";);
> +        nsReg.unregisterNamespace("foo");
> +
> +        // invalid
> +        try {
> +            nsReg.registerNamespace("foo", "example.com");
> +            fail("should not register invalid namespace name");
> +        } finally {
> +            nsReg.unregisterNamespace("foo");
> +        }
> +    }
> {noformat}
> Note that names of nodes using invalid namespaces do have an ["expanded 
> form"|https://developer.adobe.com/experience-manager/reference-materials/spec/jcr/2.0/3_Repository_Model.html#3.2.5.1%20Expanded%20Form]
>  variant that is a legal local name, e.g.
> {code:java}
> {foo}someLocalName
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to