[ 
https://issues.apache.org/jira/browse/OAK-11641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17941496#comment-17941496
 ] 

Rishabh Daim commented on OAK-11641:
------------------------------------

Hi [~reschke]

In OAK-11317, we change the behaviour by breaking the contract of ImmutableSet 
i.e. Immutability & Insertion which had been restored step by step as part of 
OAK-11473 (not completed as of now).

Unfortunately, I don't have any idea on what and which ITs have failed 
(proprietary code) and what was the reason for failure.

It could be because of our changes for OAK-11317 (that we changed the 
behaviour) OR it could be that they are using the Sets in wrong way i.e. based 
on insertion order.

Once this is fully restored, we can see if it again fails or not.

Since, we don't know about the ITs (and they are proprietary) we can improve 
the coverage for ImmutableSet replacement methods.

> Create UT/IT reproducing the issue that led to backing out changes related to 
> OAK-11470
> ---------------------------------------------------------------------------------------
>
>                 Key: OAK-11641
>                 URL: https://issues.apache.org/jira/browse/OAK-11641
>             Project: Jackrabbit Oak
>          Issue Type: Task
>            Reporter: Julian Reschke
>            Assignee: Rishabh Daim
>            Priority: Major
>
> We should have tests that check the problem that caused us to do OAK-11473.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to