[ 
https://issues.apache.org/jira/browse/OAK-11645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17941567#comment-17941567
 ] 

Manfred Baedke edited comment on OAK-11645 at 4/7/25 12:19 PM:
---------------------------------------------------------------

[~mreutegg] : That's what copilot came up with:
{code:java}
<build>
    <plugins>
        <plugin>
            <groupId>org.apache.felix</groupId>
            <artifactId>maven-bundle-plugin</artifactId>
            <version>4.2.1</version>
            <executions>
                <execution>
                    <goals>
                        <goal>baseline</goal>
                    </goals>
                    <configuration>
                        <instructions>
                            <_ignore>
                                javax.annotation.Nullable,
                                javax.annotation.Nonnull
                            </_ignore>
                        </instructions>
                    </configuration>
                </execution>
            </executions>
        </plugin>
    </plugins>
</build>
{code}
I have no idea if that even makes any sense, going to look into it. 

(The question was: Please give me an example of a configuration that will the 
plugin make ignore all changes in nullability annotations on a given API.)


was (Author: baedke):
[~mreutegg] : That's what copilot came up with:
{code:java}
<build>
    <plugins>
        <plugin>
            <groupId>org.apache.felix</groupId>
            <artifactId>maven-bundle-plugin</artifactId>
            <version>4.2.1</version>
            <executions>
                <execution>
                    <goals>
                        <goal>baseline</goal>
                    </goals>
                    <configuration>
                        <instructions>
                            <_ignore>
                                javax.annotation.Nullable,
                                javax.annotation.Nonnull
                            </_ignore>
                        </instructions>
                    </configuration>
                </execution>
            </executions>
        </plugin>
    </plugins>
</build>
{code}
I have no idea if that even makes any sense, going to look into it.

> take over package versions for shaded guava
> -------------------------------------------
>
>                 Key: OAK-11645
>                 URL: https://issues.apache.org/jira/browse/OAK-11645
>             Project: Jackrabbit Oak
>          Issue Type: Task
>          Components: shaded-guava
>            Reporter: Julian Reschke
>            Assignee: Julian Reschke
>            Priority: Major
>
> When we introduced shaded Guava (OAK-9989), we decided for simplicity to use 
> the Guava version for our package versions. So for Guava 33.4.0, we just 
> exported all packages with package version 33.4.0.
> Lately, Google has switched nullability annotations (from javax to 
> https://jspecify.dev/), which cause baseline errors, because changing 
> annotations changes the API (from bnd's point of view).
> Problem: in Guava versions, these changes happen in PATCH releases (which is 
> fine, because they do not use semantic versioning (properly)).
> Solution: change package version to something we control.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to