[ 
https://issues.apache.org/jira/browse/OAK-11657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17950333#comment-17950333
 ] 

Julian Reschke edited comment on OAK-11657 at 5/9/25 3:44 AM:
--------------------------------------------------------------

Re-opened because of a (not yet) understood test failure:

[https://ci-builds.apache.org/job/Jackrabbit/job/jackrabbit-oak-trunk/org.apache.jackrabbit$oak-jcr/2180/testReport/junit/org.apache.jackrabbit.oak.jcr.session/JackrabbitSessionTest/testGetExpandedNameBrokenNamespace/]

{code}
Failed to register namespace mapping foo -> bar


javax.jcr.NamespaceException: Failed to register namespace mapping foo -> bar
at 
org.apache.jackrabbit.oak.api.CommitFailedException.asRepositoryException(CommitFailedException.java:228)
at 
org.apache.jackrabbit.oak.plugins.name.ReadWriteNamespaceRegistry.registerNamespace(ReadWriteNamespaceRegistry.java:113)
at 
org.apache.jackrabbit.oak.jcr.session.JackrabbitSessionTest.testGetExpandedNameBrokenNamespace(JackrabbitSessionTest.java:105)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native 
Method)
at 
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at 
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:566)
at junit.framework.TestCase.runTest(TestCase.java:177)
at junit.framework.TestCase.runBare(TestCase.java:142)
at junit.framework.TestResult$1.protect(TestResult.java:122)
at junit.framework.TestResult.runProtected(TestResult.java:142)
at junit.framework.TestResult.run(TestResult.java:125)
at org.apache.jackrabbit.test.JCRTestResult.run(JCRTestResult.java:75)
at junit.framework.TestCase.run(TestCase.java:130)
at org.apache.jackrabbit.test.AbstractJCRTest.run(AbstractJCRTest.java:476)
at junit.framework.TestSuite.runTest(TestSuite.java:241)
at junit.framework.TestSuite.run(TestSuite.java:236)
at org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:90)
at 
org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:365)
at 
org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:273)
at 
org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:238)
at 
org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:159)
at 
org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:384)
at 
org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:345)
at org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:126)
at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:418)
Caused by: org.apache.jackrabbit.oak.api.CommitFailedException: 
OakNamespace0005: Namespace modification not allowed: foo
at 
org.apache.jackrabbit.oak.plugins.name.NamespaceEditor.modificationNotAllowed(NamespaceEditor.java:129)
at 
org.apache.jackrabbit.oak.plugins.name.NamespaceEditor.propertyChanged(NamespaceEditor.java:106)
at 
org.apache.jackrabbit.oak.spi.commit.CompositeEditor.propertyChanged(CompositeEditor.java:85)
at 
org.apache.jackrabbit.oak.spi.commit.EditorDiff.propertyChanged(EditorDiff.java:92)
at 
org.apache.jackrabbit.oak.segment.SegmentNodeState.compareProperties(SegmentNodeState.java:662)
at 
org.apache.jackrabbit.oak.segment.SegmentNodeState.compareAgainstBaseState(SegmentNodeState.java:556)
at 
org.apache.jackrabbit.oak.spi.commit.EditorDiff.childNodeChanged(EditorDiff.java:147)
at 
org.apache.jackrabbit.oak.segment.MapRecord$4.childNodeChanged(MapRecord.java:471)
at org.apache.jackrabbit.oak.segment.MapRecord.compare(MapRecord.java:517)
at org.apache.jackrabbit.oak.segment.MapRecord.compare(MapRecord.java:462)
at 
org.apache.jackrabbit.oak.segment.SegmentNodeState.compareAgainstBaseState(SegmentNodeState.java:649)
at 
org.apache.jackrabbit.oak.spi.commit.EditorDiff.childNodeChanged(EditorDiff.java:147)
at org.apache.jackrabbit.oak.segment.MapRecord.compare(MapRecord.java:444)
at 
org.apache.jackrabbit.oak.segment.SegmentNodeState.compareAgainstBaseState(SegmentNodeState.java:649)
at org.apache.jackrabbit.oak.spi.commit.EditorDiff.process(EditorDiff.java:51)
at 
org.apache.jackrabbit.oak.spi.commit.EditorHook.processCommit(EditorHook.java:54)
at 
org.apache.jackrabbit.oak.spi.commit.CompositeHook.processCommit(CompositeHook.java:60)
at 
org.apache.jackrabbit.oak.spi.commit.CompositeHook.processCommit(CompositeHook.java:60)
at org.apache.jackrabbit.oak.segment.scheduler.Commit.apply(Commit.java:99)
at 
org.apache.jackrabbit.oak.segment.scheduler.LockBasedScheduler.execute(LockBasedScheduler.java:299)
at 
org.apache.jackrabbit.oak.segment.scheduler.LockBasedScheduler.schedule(LockBasedScheduler.java:270)
at 
org.apache.jackrabbit.oak.segment.SegmentNodeStore.merge(SegmentNodeStore.java:212)
at org.apache.jackrabbit.oak.core.MutableRoot.commit(MutableRoot.java:261)
at org.apache.jackrabbit.oak.core.MutableRoot.commit(MutableRoot.java:272)
at 
org.apache.jackrabbit.oak.plugins.name.ReadWriteNamespaceRegistry.registerNamespace(ReadWriteNamespaceRegistry.java:110)
... 24 more

{code}



was (Author: reschke):
Re-opened because of a (not yet) understood test failure.



> JackrabbitSession.getExpandedName/Path need to return stable expanded names
> ---------------------------------------------------------------------------
>
>                 Key: OAK-11657
>                 URL: https://issues.apache.org/jira/browse/OAK-11657
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: jackrabbit-api, jcr
>    Affects Versions: 1.78.0
>            Reporter: Julian Reschke
>            Assignee: Julian Reschke
>            Priority: Major
>             Fix For: 1.80.0
>
>
> Right now,
> https://github.com/apache/jackrabbit-oak/blob/81c09d18251380c604a31c5a399d834b001c7035/oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/session/JackrabbitSessionTest.java#L74
> assumes that the expanded name changes when the session-local namespace 
> mapping changes. That's incorrect: the expanded name of an items is supposed 
> to be immutable oncer it is created; it's a stable identifier independant of 
> namespace prefix mappings.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to