On Fri, 2006-03-24 at 23:46, Tom Erickson wrote: > Peter, > > This is great stuff. It would be cool to see your JNI in Solaris.
Absolutely. I'm not sure about the precise implementation I've ended up with, though - it's become rather messy over time and really needs to be redone cleanly. > I > had a few thoughts about the jfsstat GUI. Thanks for taking the time to look! > I agree: table sorting is a terrific feature. > > The "Show" menu could use JRadioButtonMenuItem so I can see which > display is currently selected. A label on the display itself or in the > title bar might also be nice. Good point. That and the update interval too. Is in the next version... > I noticed that I kept wanting to expand the last "Device" column. > Putting the Device column first makes it easier to resize in a way > that's fair to the other columns, but I understand why you put it last > because the left edge of the string is easier to associate visually with > the data. Since I never want to resize any but the "Device" column, you > might use table.setAutoResizeMode(JTable.AUTO_RESIZE_LAST_COLUMN) so my > manual effort pays off more quickly (unfortunately > AUTO_RESIZE_ALL_COLUMNS is broken). Or you could calculate ideal column > widths based on actual data width. (And to blow me away, you could > remember manual adjustments in a preference file) :-) I was playing with this last night. And either I'm doing it all wrong, or it's doing something different to what I expect, or the TableSorter is getting in the way. Whatever, I couldn't get it to do anything sensible. I'm going to have to do this properly. What I also need to do is to customize the data display in each cell, which is going to need a custom renderer. Actually, it's on the left because it was easier to code - it's easier to construct the data arrays and then add the device name on the end rather than put the device at the beginning and move everything else along one. But that is where I find it easiest to read. Something else I've found myself doing is reordering the columns (JTable allows you to do this for free) to put the device column right next to the data column of interest to make it even easier to match up. > I was wondering what a square in a data cell means. I attached a > screenshot in case you don't see these on your system. I don't see those. My first guess is that the filesystem has been unmounted. I didn't check for that in jfsstat (it never happens on my test systems unless I explicitly do a mount or unmount so didn't get tested). Error/sanity checking wasn't as complete as it should be :-( The next version will catch this and remove the entry from the list. (The version after might even spot new entries and add them on the fly.) This actually revealed sloppy coding in the C part - I was relying on kstat_lookup failing to tell me if a kstat had been removed, and it wasn't (probably because I hadn't called kstat_chain_update). > I like the summary in the jfsstat help. That was a nice idea. Could > you include the version number in the About jfsstat window? Gosh. I just tapped something in so the window wasn't blank. It needs a bit of work. A meaningful description of what some of the statistics actually mean could be handy. Thanks for all the comments - they're all useful and being taken on board!
