On Dec 1, 2006, at 2:50 AM, Joel Becker wrote:
On Wed, Nov 29, 2006 at 09:51:30AM +0100, [EMAIL PROTECTED] wrote:
Added a global spinlock around modifications to
o2net_connected_peer (as discussed with Mark).
I have a separate patch that uses to_o2nm_cluster_from_node() but
since I cant reproduce the problem mentioned in Jeff's comment (it
apparently needs the userspace heartbeating modifications), I'd
prefer to leave it out.
Which problem do you mean? I'm trying to know if the callback
changes (->disconnect_notify()) make you happy and are good enough to
push towards mainline. Have you tested with them, etc?
I'm referring to this problem noted by Jeff
/*
* FIXME: These should use to_o2nm_cluster_from_node(), but we end up
* losing our parent link to the cluster during shutdown. This can be
* solved by adding a pre-removal callback to configfs, or passing
* around the cluster with the node. -jeffm
*/
Without the userspace heartbeat code I can't seem to create this
situation and everything works nicely.
So I'm not yet in a position to really comment on
the .disconnect_notify changes.
--
Andrew Beekhof
"Would the last person to leave please turn out the enlightenment?" -
TISM
_______________________________________________
Ocfs2-devel mailing list
Ocfs2-devel@oss.oracle.com
http://oss.oracle.com/mailman/listinfo/ocfs2-devel
