Hi Changwei, On 2018/2/23 17:55, Changwei Ge wrote: > Hi Jun, > > On 2018/2/23 17:13, piaojun wrote: >> Hi changwei, >> >> On 2018/2/23 15:30, ge.chang...@h3c.com wrote: >>> From: Changwei Ge <ge.chang...@h3c.com> >> This line seems unnecessary, others looks good to me. > I used git send-email, thus this line was added by parameter --from. > I suppose you could ignore it if it seems strange to you:-) If this won't affect the patch format, you could add: Reviewed-by: Jun Piao <piao...@huawei.com>
thanks, Jun > > Thanks, > Changwei > >> >> thanks, >> Jun >>> >>> Obviously, the comment before dlm_do_local_recovery_cleanup() has >>> nothing to do with it. So remove it. >>> >>> Signed-off-by: Changwei Ge <ge.chang...@h3c.com> >>> --- >>> fs/ocfs2/dlm/dlmrecovery.c | 7 ------- >>> 1 file changed, 7 deletions(-) >>> >>> diff --git a/fs/ocfs2/dlm/dlmrecovery.c b/fs/ocfs2/dlm/dlmrecovery.c >>> index ec8f758..65f0c54 100644 >>> --- a/fs/ocfs2/dlm/dlmrecovery.c >>> +++ b/fs/ocfs2/dlm/dlmrecovery.c >>> @@ -2331,13 +2331,6 @@ static void dlm_free_dead_locks(struct dlm_ctxt *dlm, >>> __dlm_dirty_lockres(dlm, res); >>> } >>> >>> -/* if this node is the recovery master, and there are no >>> - * locks for a given lockres owned by this node that are in >>> - * either PR or EX mode, zero out the lvb before requesting. >>> - * >>> - */ >>> - >>> - >>> static void dlm_do_local_recovery_cleanup(struct dlm_ctxt *dlm, u8 >>> dead_node) >>> { >>> struct dlm_lock_resource *res; >>> >> > . > _______________________________________________ Ocfs2-devel mailing list Ocfs2-devel@oss.oracle.com https://oss.oracle.com/mailman/listinfo/ocfs2-devel