On 2018/4/2 12:32, piaojun wrote: > Hi Changwei, > > On 2018/4/2 10:59, Changwei Ge wrote: >> Hi Jun, >> >> It seems that you have ever posted this patch, If I remember correctly. >> My concern is still if you disable dlm recovery via ::migrate_done. Then flag >> DLM_LOCK_RES_RECOVERING can't be cleared. > After I set migrate_done, all lockres had been migrated. So there won't be > any lockres with DLM_LOCK_RES_RECOVERING. And I have tested this patch for > a few months.
Oops, Yes, it makes sense. > > thanks, > Jun >> >> So we can't purge the problematic lock resource since __dlm_lockres_unused() >> needs to check that flag. >> >> Finally, umount will run the while loop in dlm_migrate_all_locks() >> infinitely. >> Or if I miss something? >> >> Thanks, >> Changwei >> >> On 2018/3/15 21:00, piaojun wrote: >>> >>> Fixes: bc9838c4d44a ("dlm: allow dlm do recovery during shutdown") >>> >>> Signed-off-by: Jun Piao <piao...@huawei.com> >>> Reviewed-by: Alex Chen <alex.c...@huawei.com> >>> Reviewed-by: Yiwen Jiang <jiangyi...@huawei.com> Acked-by: Changwei Ge <ge.chang...@h3c.com> >>> --- >>> fs/ocfs2/dlm/dlmcommon.h | 1 + >>> fs/ocfs2/dlm/dlmdomain.c | 15 +++++++++++++++ >>> fs/ocfs2/dlm/dlmrecovery.c | 13 ++++++++++--- >>> 3 files changed, 26 insertions(+), 3 deletions(-) >>> >>> diff --git a/fs/ocfs2/dlm/dlmcommon.h b/fs/ocfs2/dlm/dlmcommon.h _______________________________________________ Ocfs2-devel mailing list Ocfs2-devel@oss.oracle.com https://oss.oracle.com/mailman/listinfo/ocfs2-devel